Commit f4a1f04a authored Dec 15, 2016 by Golan Ben Ami Committed by Luca Coelho Feb 08, 2017

iwlwifi: pcie: Re-configure IVAR table after stop device



When getting RF_KILL and disabling radio, the device gets stopped
and reset. This erases the IVAR table that matches the interrupt
to its cause, and is essential for MSIX proper functionality.
Till now, the table wasn't re-configured after the reset, and
therefore the interrupt that enabled radio didn't fire on the
right irq, and the driver didn't handle it correctly.

To fix this, configure the IVAR table again after resetting the
device.

Signed-off-by: Golan Ben-Ami <golan.ben.ami@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent d7270d61

drivers/net/wireless/intel/iwlwifi/pcie/trans.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -1245,6 +1245,15 @@ static void _iwl_trans_pcie_stop_device(struct iwl_trans *trans, bool low_power)
		iwl_write32(trans, CSR_RESET, CSR_RESET_REG_FLAG_SW_RESET);
		usleep_range(1000, 2000);

		/*
		* Upon stop, the IVAR table gets erased, so msi-x won't
		* work. This causes a bug in RF-KILL flows, since the interrupt
		* that enables radio won't fire on the correct irq, and the
		* driver won't be able to handle the interrupt.
		* Configure the IVAR table again after reset.
		*/
		iwl_pcie_conf_msix_hw(trans_pcie);

		/*
		* Upon stop, the APM issues an interrupt if HW RF kill is set.
		* This is a bug in certain verions of the hardware.