Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f491dbe0 authored by Joe Perches's avatar Joe Perches Committed by Mauro Carvalho Chehab
Browse files

[media] dvb-net: Fix probable mask then right shift defects 



Precedence of & and >> is not the same and is not left to right.
shift has higher precedence and should be done after the mask.

Add parentheses around the mask.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent e5f3d00c

drivers/media/dvb-core/dvb_net.c

+3 −1
Original line number Diff line number Diff line
@@ -379,7 +379,9 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_len ) 
			/* Check TS error conditions: sync_byte, transport_error_indicator, scrambling_control . */

			if ((ts[0] != TS_SYNC) || (ts[1] & TS_TEI) || ((ts[3] & TS_SC) != 0)) {

				printk(KERN_WARNING "%lu: Invalid TS cell: SYNC %#x, TEI %u, SC %#x.\n",

				       priv->ts_count, ts[0], ts[1] & TS_TEI >> 7, ts[3] & 0xC0 >> 6);

				       priv->ts_count, ts[0],

				       (ts[1] & TS_TEI) >> 7,

				       (ts[3] & 0xC0) >> 6);



				/* Drop partly decoded SNDU, reset state, resync on PUSI. */

				if (priv->ule_skb) {