Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4044dac authored by Eli Cohen's avatar Eli Cohen Committed by Leon Romanovsky
Browse files

IB/mlx5: Fix error handling order in create_kernel_qp 



Make sure order of cleanup is exactly the opposite of initialization.

Fixes: 9603b61d ('mlx5: Move pci device handling from mlx5_ib to mlx5_core')
Signed-off-by: default avatarEli Cohen <eli@mellanox.com>
Reviewed-by: default avatarMatan Barak <matanb@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent de8d6e02

drivers/infiniband/hw/mlx5/qp.c

+2 −2
Original line number Diff line number Diff line
@@ -994,12 +994,12 @@ static int create_kernel_qp(struct mlx5_ib_dev *dev, 
	return 0;



err_wrid:

	mlx5_db_free(dev->mdev, &qp->db);

	kfree(qp->sq.wqe_head);

	kfree(qp->sq.w_list);

	kfree(qp->sq.wrid);

	kfree(qp->sq.wr_data);

	kfree(qp->rq.wrid);

	mlx5_db_free(dev->mdev, &qp->db);



err_free:

	kvfree(*in);
@@ -1014,12 +1014,12 @@ static int create_kernel_qp(struct mlx5_ib_dev *dev, 


static void destroy_qp_kernel(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp)

{

	mlx5_db_free(dev->mdev, &qp->db);

	kfree(qp->sq.wqe_head);

	kfree(qp->sq.w_list);

	kfree(qp->sq.wrid);

	kfree(qp->sq.wr_data);

	kfree(qp->rq.wrid);

	mlx5_db_free(dev->mdev, &qp->db);

	mlx5_buf_free(dev->mdev, &qp->buf);

	free_uuar(&dev->mdev->priv.uuari, qp->bf->uuarn);

}