Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3dfd208 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

af_unix: fix bug on large send() 



commit e370a723 ("af_unix: improve STREAM behavior with fragmented
memory") added a bug on large send() because the
skb_copy_datagram_from_iovec() call always start from the beginning
of iovec.

We must instead use the @sent variable to properly skip the
already processed part.

Reported-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6c821bd9

net/unix/af_unix.c

+2 −1
Original line number Diff line number Diff line
@@ -1669,7 +1669,8 @@ static int unix_stream_sendmsg(struct kiocb *kiocb, struct socket *sock, 
		skb_put(skb, size - data_len);

		skb->data_len = data_len;

		skb->len = size;

		err = skb_copy_datagram_from_iovec(skb, 0, msg->msg_iov, 0, size);

		err = skb_copy_datagram_from_iovec(skb, 0, msg->msg_iov,

						   sent, size);

		if (err) {

			kfree_skb(skb);

			goto out_err;