Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3b28362 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Marc Zyngier
Browse files

irqchip/s3c24xx: Remove unneeded comparison of unsigned long to 0 



irq_data->hwirq is unsigned long.  This fixes GCC warning:

    drivers/irqchip/irq-s3c24xx.c: In function 's3c_irqext0_type':
    drivers/irqchip/irq-s3c24xx.c:253:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
                       ^~

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 4096165d

drivers/irqchip/irq-s3c24xx.c

+1 −1
Original line number Diff line number Diff line
@@ -250,7 +250,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type) 
	void __iomem *gpcon_reg;

	unsigned long gpcon_offset, extint_offset;



	if ((data->hwirq >= 0) && (data->hwirq <= 3)) {

	if (data->hwirq <= 3) {

		gpcon_reg = S3C2410_GPFCON;

		extint_reg = S3C24XX_EXTINT0;

		gpcon_offset = (data->hwirq) * 2;