Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f36bb0ca authored by Gabor Juhos's avatar Gabor Juhos Committed by John W. Linville
Browse files

rt2x00: rt2800lib: fix LNA_A[12] gain values for RT3593 



The LNA_A[12] gain values are stored at a different
offset in the EEPROM on RT3593 based devices. However
the current code unconditionally reads those values
from the location used by other chipsets.

Fix the code to use the correct EEPROM offset.

Based on the DPO_RT5572_LinuxSTA_2.6.0.1_20120629
driver.

References:
  RT3593_EEPROM_RSSI2_OFFSET_ALNAGAIN1_24G_READ in include/chip/rt3593.h
  RT3593_EEPROM_RSSI2_OFFSET_ALNAGAIN2_5G_READ in include/chip/rt3593.h

Signed-off-by: default avatarGabor Juhos <juhosg@openwrt.org>
Acked-by: default avatarStanislaw Gruszka <stf_xl@wp.pl>
Acked-by: default avatarGertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 6316c786

drivers/net/wireless/rt2x00/rt2800.h

+4 −0
Original line number Diff line number Diff line
@@ -2672,6 +2672,10 @@ enum rt2800_eeprom_word { 
#define EEPROM_BBP_VALUE		FIELD16(0x00ff)

#define EEPROM_BBP_REG_ID		FIELD16(0xff00)



/* EEPROM_EXT_LNA2 */

#define EEPROM_EXT_LNA2_A1		FIELD16(0x00ff)

#define EEPROM_EXT_LNA2_A2		FIELD16(0xff00)



/*

 * EEPROM IQ Calibration, unlike other entries those are byte addresses.

 */

drivers/net/wireless/rt2x00/rt2800lib.c

+43 −12
Original line number Diff line number Diff line
@@ -1826,11 +1826,25 @@ static void rt2800_config_lna_gain(struct rt2x00_dev *rt2x00dev, 
		rt2800_eeprom_read(rt2x00dev, EEPROM_LNA, &eeprom);

		lna_gain = rt2x00_get_field16(eeprom, EEPROM_LNA_A0);

	} else if (libconf->rf.channel <= 128) {

		if (rt2x00_rt(rt2x00dev, RT3593)) {

			rt2800_eeprom_read(rt2x00dev, EEPROM_EXT_LNA2, &eeprom);

			lna_gain = rt2x00_get_field16(eeprom,

						      EEPROM_EXT_LNA2_A1);

		} else {

			rt2800_eeprom_read(rt2x00dev, EEPROM_RSSI_BG2, &eeprom);

		lna_gain = rt2x00_get_field16(eeprom, EEPROM_RSSI_BG2_LNA_A1);

			lna_gain = rt2x00_get_field16(eeprom,

						      EEPROM_RSSI_BG2_LNA_A1);

		}

	} else {

		if (rt2x00_rt(rt2x00dev, RT3593)) {

			rt2800_eeprom_read(rt2x00dev, EEPROM_EXT_LNA2, &eeprom);

			lna_gain = rt2x00_get_field16(eeprom,

						      EEPROM_EXT_LNA2_A2);

		} else {

			rt2800_eeprom_read(rt2x00dev, EEPROM_RSSI_A2, &eeprom);

		lna_gain = rt2x00_get_field16(eeprom, EEPROM_RSSI_A2_LNA_A2);

			lna_gain = rt2x00_get_field16(eeprom,

						      EEPROM_RSSI_A2_LNA_A2);

		}

	}



	rt2x00dev->lna_gain = lna_gain;
@@ -6488,10 +6502,12 @@ static int rt2800_validate_eeprom(struct rt2x00_dev *rt2x00dev) 
	rt2800_eeprom_read(rt2x00dev, EEPROM_RSSI_BG2, &word);

	if (abs(rt2x00_get_field16(word, EEPROM_RSSI_BG2_OFFSET2)) > 10)

		rt2x00_set_field16(&word, EEPROM_RSSI_BG2_OFFSET2, 0);

	if (!rt2x00_rt(rt2x00dev, RT3593)) {

		if (rt2x00_get_field16(word, EEPROM_RSSI_BG2_LNA_A1) == 0x00 ||

		    rt2x00_get_field16(word, EEPROM_RSSI_BG2_LNA_A1) == 0xff)

			rt2x00_set_field16(&word, EEPROM_RSSI_BG2_LNA_A1,

					   default_lna_gain);

	}

	rt2800_eeprom_write(rt2x00dev, EEPROM_RSSI_BG2, word);



	drv_data->txmixer_gain_5g = rt2800_get_txmixer_gain_5g(rt2x00dev);
@@ -6506,12 +6522,27 @@ static int rt2800_validate_eeprom(struct rt2x00_dev *rt2x00dev) 
	rt2800_eeprom_read(rt2x00dev, EEPROM_RSSI_A2, &word);

	if (abs(rt2x00_get_field16(word, EEPROM_RSSI_A2_OFFSET2)) > 10)

		rt2x00_set_field16(&word, EEPROM_RSSI_A2_OFFSET2, 0);

	if (!rt2x00_rt(rt2x00dev, RT3593)) {

		if (rt2x00_get_field16(word, EEPROM_RSSI_A2_LNA_A2) == 0x00 ||

		    rt2x00_get_field16(word, EEPROM_RSSI_A2_LNA_A2) == 0xff)

			rt2x00_set_field16(&word, EEPROM_RSSI_A2_LNA_A2,

					   default_lna_gain);

	}

	rt2800_eeprom_write(rt2x00dev, EEPROM_RSSI_A2, word);



	if (rt2x00_rt(rt2x00dev, RT3593)) {

		rt2800_eeprom_read(rt2x00dev, EEPROM_EXT_LNA2, &word);

		if (rt2x00_get_field16(word, EEPROM_EXT_LNA2_A1) == 0x00 ||

		    rt2x00_get_field16(word, EEPROM_EXT_LNA2_A1) == 0xff)

			rt2x00_set_field16(&word, EEPROM_EXT_LNA2_A1,

					   default_lna_gain);

		if (rt2x00_get_field16(word, EEPROM_EXT_LNA2_A2) == 0x00 ||

		    rt2x00_get_field16(word, EEPROM_EXT_LNA2_A2) == 0xff)

			rt2x00_set_field16(&word, EEPROM_EXT_LNA2_A1,

					   default_lna_gain);

		rt2800_eeprom_write(rt2x00dev, EEPROM_EXT_LNA2, word);

	}



	return 0;

}