Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f34d0650 authored by Eldad Zack's avatar Eldad Zack Committed by Takashi Iwai
Browse files

ALSA: usb-audio: reverse condition logic in set_sync_endpoint 



Reverse logic on the conditions required to qualify for a sync endpoint
and remove one level of indendation.

Signed-off-by: default avatarEldad Zack <eldad@fogrefinery.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent a60945fd

sound/usb/pcm.c

+42 −39
Original line number Diff line number Diff line
@@ -419,9 +419,13 @@ static int set_sync_endpoint(struct snd_usb_substream *subs, 
	if (err < 0)

		return err;



	if (((is_playback && attr == USB_ENDPOINT_SYNC_ASYNC) ||

	     (!is_playback && attr == USB_ENDPOINT_SYNC_ADAPTIVE)) &&

	    altsd->bNumEndpoints >= 2) {

	if (altsd->bNumEndpoints < 2)

		return 0;



	if ((is_playback && attr != USB_ENDPOINT_SYNC_ASYNC) ||

	    (!is_playback && attr != USB_ENDPOINT_SYNC_ADAPTIVE))

		return 0;



	/* check sync-pipe endpoint */

	/* ... and check descriptor size before accessing bSynchAddress

	   because there is a version of the SB Audigy 2 NX firmware lacking
@@ -460,7 +464,6 @@ static int set_sync_endpoint(struct snd_usb_substream *subs, 
		return -EINVAL;



	subs->data_endpoint->sync_master = subs->sync_endpoint;

	}



	return 0;

}