Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f339664c authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files

IBM-EMAC: Delete an unnecessary check before the function call "of_dev_put" 



The of_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9ba11ac0

drivers/net/ethernet/ibm/emac/core.c

+1 −1
Original line number Diff line number Diff line
@@ -2367,7 +2367,7 @@ static int emac_wait_deps(struct emac_instance *dev) 
	err = emac_check_deps(dev, deps) ? 0 : -ENODEV;

	for (i = 0; i < EMAC_DEP_COUNT; i++) {

		of_node_put(deps[i].node);

		if (err && deps[i].ofdev)

		if (err)

			of_dev_put(deps[i].ofdev);

	}

	if (err == 0) {