Commit f2edd9f6 authored Apr 15, 2017 by Sebastian Reichel Committed by Marcel Holtmann Apr 22, 2017

Bluetooth: hci_ll: Fix NULL pointer deref on FW upload failure



Avoid NULL pointer dereference occurring due to freeing
skb containing an error pointer. It can easily be triggered
by using the driver with broken uart (i.e. due to misconfigured
pinmuxing).

Fixes: 37180552 ("bluetooth: hci_uart: add LL protocol serdev driver support")
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent fb796707

drivers/bluetooth/hci_ll.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -537,8 +537,7 @@ static int read_local_version(struct hci_dev *hdev)
		if (IS_ERR(skb)) {
		bt_dev_err(hdev, "Reading TI version information failed (%ld)",
		PTR_ERR(skb));
		err = PTR_ERR(skb);
		goto out;
		return PTR_ERR(skb);
		}
		if (skb->len != sizeof(*ver)) {
		err = -EILSEQ;