Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2772575 authored by Len Brown's avatar Len Brown
Browse files

ACPI: hp-wmi, msi-wmi: clarify that wmi_install_notify_handler() returns an acpi_status 



Emphasize that that wmi_install_notify_handler() returns an acpi_status
rather than -errno by by testing ACPI_SUCCESS(), ACPI_FAILURE().

No functional change in this patch, but this confusion caused a bug in dell-wmi.

Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent abb631bf

drivers/platform/x86/hp-wmi.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -581,7 +581,7 @@ static int __init hp_wmi_init(void) 
	if (wmi_has_guid(HPWMI_EVENT_GUID)) {

	if (wmi_has_guid(HPWMI_EVENT_GUID)) {

		err = wmi_install_notify_handler(HPWMI_EVENT_GUID,

		err = wmi_install_notify_handler(HPWMI_EVENT_GUID,

						 hp_wmi_notify, NULL);

						 hp_wmi_notify, NULL);

		if (!err)

		if (ACPI_SUCCESS(err))

			hp_wmi_input_setup();

			hp_wmi_input_setup();

	}

	}

drivers/platform/x86/msi-wmi.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -236,7 +236,7 @@ static int __init msi_wmi_init(void) 
	}

	}

	err = wmi_install_notify_handler(MSIWMI_EVENT_GUID,

	err = wmi_install_notify_handler(MSIWMI_EVENT_GUID,

			msi_wmi_notify, NULL);

			msi_wmi_notify, NULL);

	if (err)

	if (ACPI_FAILURE(err))

		return -EINVAL;

		return -EINVAL;





	err = msi_wmi_input_setup();

	err = msi_wmi_input_setup();