Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f251c83d authored by Theodore Ts'o's avatar Theodore Ts'o Committed by Greg Kroah-Hartman
Browse files

ext4: disallow files with EXT4_JOURNAL_DATA_FL from EXT4_IOC_SWAP_BOOT 



[ Upstream commit 6e589291f4b1b700ca12baec5930592a0d51e63c ]

A malicious/clueless root user can use EXT4_IOC_SWAP_BOOT to force a
corner casew which can lead to the file system getting corrupted.
There's no usefulness to allowing this, so just prohibit this case.

Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent cc4d8283

fs/ext4/ioctl.c

+1 −0
Original line number Diff line number Diff line
@@ -132,6 +132,7 @@ static long swap_inode_boot_loader(struct super_block *sb, 


	if (inode->i_nlink != 1 || !S_ISREG(inode->i_mode) ||

	    IS_SWAPFILE(inode) || IS_ENCRYPTED(inode) ||

	    (EXT4_I(inode)->i_flags & EXT4_JOURNAL_DATA_FL) ||

	    ext4_has_inline_data(inode)) {

		err = -EINVAL;

		goto journal_err_out;