Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f21a38c4 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: refactor pcl725 driver to remove forward declarations 



Move the module_init/module_exit routines and the associated
struct comedi_driver and other variables to the end of the source.
This is more typical of how other drivers are written and removes
the need for the forward declarations.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ccc66e0a

drivers/staging/comedi/drivers/pcl725.c

+19 −23
Original line number Diff line number Diff line
@@ -20,29 +20,6 @@ Devices: [Advantech] PCL-725 (pcl725) 
#define PCL725_DO 0

#define PCL725_DI 1



static int pcl725_attach(struct comedi_device *dev,

			 struct comedi_devconfig *it);

static int pcl725_detach(struct comedi_device *dev);

static struct comedi_driver driver_pcl725 = {

	.driver_name = "pcl725",

	.module = THIS_MODULE,

	.attach = pcl725_attach,

	.detach = pcl725_detach,

};



static int __init driver_pcl725_init_module(void)

{

	return comedi_driver_register(&driver_pcl725);

}



static void __exit driver_pcl725_cleanup_module(void)

{

	comedi_driver_unregister(&driver_pcl725);

}



module_init(driver_pcl725_init_module);

module_exit(driver_pcl725_cleanup_module);



static int pcl725_do_insn(struct comedi_device *dev, struct comedi_subdevice *s,

			  struct comedi_insn *insn, unsigned int *data)

{
@@ -122,6 +99,25 @@ static int pcl725_detach(struct comedi_device *dev) 
	return 0;

}



static struct comedi_driver driver_pcl725 = {

	.driver_name	= "pcl725",

	.module		= THIS_MODULE,

	.attach		= pcl725_attach,

	.detach		= pcl725_detach,

};



static int __init driver_pcl725_init_module(void)

{

	return comedi_driver_register(&driver_pcl725);

}

module_init(driver_pcl725_init_module);



static void __exit driver_pcl725_cleanup_module(void)

{

	comedi_driver_unregister(&driver_pcl725);

}

module_exit(driver_pcl725_cleanup_module);



MODULE_AUTHOR("Comedi http://www.comedi.org");

MODULE_DESCRIPTION("Comedi low-level driver");

MODULE_LICENSE("GPL");