Commit f20b4f22 authored Apr 06, 2018 by Colin Ian King Committed by Jarkko Sakkinen May 09, 2018

tpm: st33zp24: remove redundant null check on chip

Currently chip is being dereferenced by the call to dev_get_drvdata
before it is being null checked, however, chip can never be null, so
this check is misleading and redundant. Remove it.

Detected by CoverityScan, CID#1357806 ("Dereference before null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jarkko Sakkinen <jarkkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkkko.sakkinen@linux.intel.com>

parent 92980756

drivers/char/tpm/st33zp24/st33zp24.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -373,8 +373,6 @@ static int st33zp24_send(struct tpm_chip chip, unsigned char buf,
		int ret;
		u8 data;

		if (!chip)
		return -EBUSY;
		if (len < TPM_HEADER_SIZE)
		return -EBUSY;