Commit f20b161f authored Jan 21, 2017 by Guenter Roeck Committed by Dmitry Torokhov Jan 21, 2017

Input: serio - drop unnecessary calls to device_init_wakeup



Calling device_init_wakeup in the remove function is unnecessary since the
device is going away, and thus won't be able to cause any wakeups under any
circumstances. Besides, the driver cleanup code already handles the
necessary cleanup.

Similarly, disabling wakeup in the probe error path is unnecessary, as is
disabling wakeup in the probe function in the first place.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 8e1b4d83

drivers/input/serio/hyperv-keyboard.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -402,7 +402,6 @@ static int hv_kbd_remove(struct hv_device *hv_dev)
		{
		struct hv_kbd_dev *kbd_dev = hv_get_drvdata(hv_dev);

		device_init_wakeup(&hv_dev->device, false);
		serio_unregister_port(kbd_dev->hv_serio);
		vmbus_close(hv_dev->channel);
		kfree(kbd_dev);