Commit f1dfa84c authored Mar 23, 2021 by Arnd Bergmann Committed by Greg Kroah-Hartman May 22, 2021

irqchip/gic-v3: Fix OF_BAD_ADDR error handling



[ Upstream commit 8e13d96670a4c050d4883e6743a9e9858e5cfe10 ]

When building with extra warnings enabled, clang points out a
mistake in the error handling:

drivers/irqchip/irq-gic-v3-mbi.c:306:21: error: result of comparison of constant 18446744073709551615 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
                if (mbi_phys_base == OF_BAD_ADDR) {

Truncate the constant to the same type as the variable it gets compared
to, to shut make the check work and void the warning.

Fixes: 50528752 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210323131842.2773094-1-arnd@kernel.org


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 191d92a2

drivers/irqchip/irq-gic-v3-mbi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -297,7 +297,7 @@ int __init mbi_init(struct fwnode_handle fwnode, struct irq_domain parent)
		reg = of_get_property(np, "mbi-alias", NULL);
		if (reg) {
		mbi_phys_base = of_translate_address(np, reg);
		if (mbi_phys_base == OF_BAD_ADDR) {
		if (mbi_phys_base == (phys_addr_t)OF_BAD_ADDR) {
		ret = -ENXIO;
		goto err_free_mbi;
		}