Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1daa40b authored by Alasdair G Kergon's avatar Alasdair G Kergon Committed by Linus Torvalds
Browse files

[PATCH] device-mapper dm-emc: Fix a memset 



The dm emc hardware handler code memset the hardware handler structure to zero
AFTER it had initialized the structure's spinlock field.

Signed-Off-By: default avatarAlasdair G Kergon <agk@redhat.com>
From: Dave Olien <dmo@osdl.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent c557308e

drivers/md/dm-emc.c

+3 −3
Original line number Diff line number Diff line
@@ -223,8 +223,10 @@ static struct emc_handler *alloc_emc_handler(void) 
{

	struct emc_handler *h = kmalloc(sizeof(*h), GFP_KERNEL);



	if (h)

	if (h) {

		memset(h, 0, sizeof(*h));

		spin_lock_init(&h->lock);

	}



	return h;

}
@@ -259,8 +261,6 @@ static int emc_create(struct hw_handler *hwh, unsigned argc, char **argv) 
	if (!h)

		return -ENOMEM;



	memset(h, 0, sizeof(*h));



	hwh->context = h;



	if ((h->short_trespass = short_trespass))