Commit f18affbe authored Jan 02, 2018 by Geert Uytterhoeven Committed by Joerg Roedel Jan 17, 2018

iommu/omap: Fix debugfs_create_*() usage



When exposing data access through debugfs, the correct
debugfs_create_*() functions must be used, depending on data type.

Remove all casts from data pointers passed to debugfs_create_*()
functions, as such casts prevent the compiler from flagging bugs.

omap_iommu.nr_tlb_entries is "int", hence casting to "u8 *" exposes only
a part of it.  Fix this by using debugfs_create_u32() instead.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent a8750ddc

drivers/iommu/omap-iommu-debug.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -274,8 +274,8 @@ void omap_iommu_debugfs_add(struct omap_iommu *obj)
		if (!obj->debug_dir)
		return;

		d = debugfs_create_u8("nr_tlb_entries", 0400, obj->debug_dir,
		(u8 *)&obj->nr_tlb_entries);
		d = debugfs_create_u32("nr_tlb_entries", 0400, obj->debug_dir,
		&obj->nr_tlb_entries);
		if (!d)
		return;