Commit f17c811d authored Sep 17, 2010 by Yong Wang Committed by Jean Delvare Sep 17, 2010

hwmon: (emc1403) Remove unnecessary hwmon_device_unregister



It is unnecessary and wrong to call hwmon_device_unregister in error
handling before hwmon_device_register is called.

Signed-off-by: Yong Wang <yong.y.wang@intel.com>
Reviewed-by: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: stable@kernel.org
Signed-off-by: Jean Delvare <khali@linux-fr.org>

parent c3b327d6

drivers/hwmon/emc1403.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -308,7 +308,6 @@ static int emc1403_probe(struct i2c_client *client,
		res = sysfs_create_group(&client->dev.kobj, &m_thermal_gr);
		if (res) {
		dev_warn(&client->dev, "create group failed\n");
		hwmon_device_unregister(data->hwmon_dev);
		goto thermal_error1;
		}
		data->hwmon_dev = hwmon_device_register(&client->dev);