Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0fe3cd7 authored by Dirk Brandewie's avatar Dirk Brandewie Committed by Rafael J. Wysocki
Browse files

intel_pstate: Correct rounding in busy calculation 



Changing to fixed point math throughout the busy calculation in
commit e66c1768 (Change busy calculation to use fixed point
math.) Introduced some inaccuracies by rounding the busy value at two
points in the calculation.  This change removes roundings and moves
the rounding to the output of the PID where the calculations are
complete and the value returned as an integer.

Fixes: e66c1768 (intel_pstate: Change busy calculation to use fixed point math.)
Reported-by: default avatarDoug Smythies <dsmythies@telus.net>
Cc: 3.14+ <stable@vger.kernel.org> # 3.14+
Signed-off-by: default avatarDirk Brandewie <dirk.j.brandewie@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent adacdf3f

drivers/cpufreq/intel_pstate.c

+7 −5
Original line number Diff line number Diff line
@@ -40,10 +40,10 @@ 
#define BYT_TURBO_VIDS		0x66d





#define FRAC_BITS 6

#define FRAC_BITS 8

#define int_tofp(X) ((int64_t)(X) << FRAC_BITS)

#define fp_toint(X) ((X) >> FRAC_BITS)

#define FP_ROUNDUP(X) ((X) += 1 << FRAC_BITS)





static inline int32_t mul_fp(int32_t x, int32_t y)

{
@@ -198,7 +198,10 @@ static signed int pid_calc(struct _pid *pid, int32_t busy) 
	pid->last_err = fp_error;



	result = pterm + mul_fp(pid->integral, pid->i_gain) + dterm;



	if (result >= 0)

		result = result + (1 << (FRAC_BITS-1));

	else

		result = result - (1 << (FRAC_BITS-1));

	return (signed int)fp_toint(result);

}
@@ -563,7 +566,6 @@ static inline void intel_pstate_calc_busy(struct cpudata *cpu, 
	core_pct = div_fp(int_tofp((sample->aperf)),

			int_tofp((sample->mperf)));

	core_pct = mul_fp(core_pct, int_tofp(100));

	FP_ROUNDUP(core_pct);



	sample->freq = fp_toint(

		mul_fp(int_tofp(cpu->pstate.max_pstate * 1000), core_pct));
@@ -609,7 +611,7 @@ static inline int32_t intel_pstate_get_scaled_busy(struct cpudata *cpu) 
	max_pstate = int_tofp(cpu->pstate.max_pstate);

	current_pstate = int_tofp(cpu->pstate.current_pstate);

	core_busy = mul_fp(core_busy, div_fp(max_pstate, current_pstate));

	return FP_ROUNDUP(core_busy);

	return core_busy;

}



static inline void intel_pstate_adjust_busy_pstate(struct cpudata *cpu)