Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0acd28c authored by Markus Elfring's avatar Markus Elfring Committed by Takashi Iwai
Browse files

ALSA: hda: Deletion of unnecessary checks before two function calls 



The functions kfree() and release_firmware() test whether their argument
is NULL and then return immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent b8eca77e

sound/pci/hda/hda_codec.c

+1 −2
Original line number Diff line number Diff line
@@ -834,7 +834,6 @@ static void snd_hda_bus_free(struct hda_bus *bus) 
	WARN_ON(!list_empty(&bus->codec_list));

	if (bus->workq)

		flush_workqueue(bus->workq);

	if (bus->unsol)

	kfree(bus->unsol);

	if (bus->ops.private_free)

		bus->ops.private_free(bus);

sound/pci/hda/hda_intel.c

+1 −2
Original line number Diff line number Diff line
@@ -1130,7 +1130,6 @@ static int azx_free(struct azx *chip) 
	pci_disable_device(chip->pci);

	kfree(chip->azx_dev);

#ifdef CONFIG_SND_HDA_PATCH_LOADER

	if (chip->fw)

	release_firmware(chip->fw);

#endif

	if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL) {