Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit efca4885 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

sparc64: move dereference after check for NULL 



We shouldn't dereference "iommu" until after we have checked that it is
non-NULL.

Fixes: f08978b0 ("sparc64: Enable sun4v dma ops to use IOMMU v2 APIs")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b1ebb975

arch/sparc/kernel/pci_sun4v.c

+2 −3
Original line number Diff line number Diff line
@@ -478,10 +478,9 @@ static int dma_4v_map_sg(struct device *dev, struct scatterlist *sglist, 
	BUG_ON(direction == DMA_NONE);



	iommu = dev->archdata.iommu;

	atu = iommu->atu;



	if (nelems == 0 || !iommu)

		return 0;

	atu = iommu->atu;



	prot = HV_PCI_MAP_ATTR_READ;

	if (direction != DMA_TO_DEVICE)