Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef73e632 authored by Jingoo Han's avatar Jingoo Han Committed by Linus Torvalds
Browse files

drivers/video/backlight/l4f00242t03.c: check return value of regulator_enable() 



regulator_enable() is marked as as __must_check.  Therefore the return
value of regulator_enable() should be checked.  Also, this patch checks
return value of regulator_set_voltage().

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8541b827

drivers/video/backlight/l4f00242t03.c

+23 −4
Original line number Diff line number Diff line
@@ -51,14 +51,33 @@ static void l4f00242t03_lcd_init(struct spi_device *spi) 
	struct l4f00242t03_pdata *pdata = spi->dev.platform_data;

	struct l4f00242t03_priv *priv = spi_get_drvdata(spi);

	const u16 cmd[] = { 0x36, param(0), 0x3A, param(0x60) };

	int ret;



	dev_dbg(&spi->dev, "initializing LCD\n");



	regulator_set_voltage(priv->io_reg, 1800000, 1800000);

	regulator_enable(priv->io_reg);

	ret = regulator_set_voltage(priv->io_reg, 1800000, 1800000);

	if (ret) {

		dev_err(&spi->dev, "failed to set the IO regulator voltage.\n");

		return;

	}

	ret = regulator_enable(priv->io_reg);

	if (ret) {

		dev_err(&spi->dev, "failed to enable the IO regulator.\n");

		return;

	}



	regulator_set_voltage(priv->core_reg, 2800000, 2800000);

	regulator_enable(priv->core_reg);

	ret = regulator_set_voltage(priv->core_reg, 2800000, 2800000);

	if (ret) {

		dev_err(&spi->dev, "failed to set the core regulator voltage.\n");

		regulator_disable(priv->io_reg);

		return;

	}

	ret = regulator_enable(priv->core_reg);

	if (ret) {

		dev_err(&spi->dev, "failed to enable the core regulator.\n");

		regulator_disable(priv->io_reg);

		return;

	}



	l4f00242t03_reset(pdata->reset_gpio);