Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef6899cd authored by Colin Ian King's avatar Colin Ian King Committed by Tomi Valkeinen
Browse files

fbdev/broadsheetfb: fix memory leak 



static code analysis from cppcheck reports:

[drivers/video/fbdev/broadsheetfb.c:673]:
  (error) Memory leak: sector_buffer

sector_buffer is not being kfree'd on each call to
broadsheet_spiflash_rewrite_sector(), so free it.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent d9e02019

drivers/video/fbdev/broadsheetfb.c

+5 −3
Original line number Diff line number Diff line
@@ -636,7 +636,7 @@ static int broadsheet_spiflash_rewrite_sector(struct broadsheetfb_par *par, 
		err = broadsheet_spiflash_read_range(par, start_sector_addr,

						data_start_addr, sector_buffer);

		if (err)

			return err;

			goto out;

	}



	/* now we copy our data into the right place in the sector buffer */
@@ -657,7 +657,7 @@ static int broadsheet_spiflash_rewrite_sector(struct broadsheetfb_par *par, 
		err = broadsheet_spiflash_read_range(par, tail_start_addr,

			tail_len, sector_buffer + tail_start_addr);

		if (err)

			return err;

			goto out;

	}



	/* if we got here we have the full sector that we want to rewrite. */
@@ -665,11 +665,13 @@ static int broadsheet_spiflash_rewrite_sector(struct broadsheetfb_par *par, 
	/* first erase the sector */

	err = broadsheet_spiflash_erase_sector(par, start_sector_addr);

	if (err)

		return err;

		goto out;



	/* now write it */

	err = broadsheet_spiflash_write_sector(par, start_sector_addr,

					sector_buffer, sector_size);

out:

	kfree(sector_buffer);

	return err;

}