Commit ef13ecbc authored Aug 30, 2017 by Dan Carpenter Committed by Jens Axboe Sep 01, 2017

kernfs: checking for IS_ERR() instead of NULL



The kernfs_get_inode() returns NULL on error, it never returns error
pointers.

Fixes: aa818825 ("kernfs: add exportfs operations")
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 974c5856

fs/kernfs/mount.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -99,8 +99,8 @@ static struct inode kernfs_fh_get_inode(struct super_block sb,
		return ERR_PTR(-ESTALE);
		inode = kernfs_get_inode(sb, kn);
		kernfs_put(kn);
		if (IS_ERR(inode))
		return ERR_CAST(inode);
		if (!inode)
		return ERR_PTR(-ESTALE);

		if (generation && inode->i_generation != generation) {
		/* we didn't find the right inode.. */