Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee5309d5 authored by Chunming Zhou's avatar Chunming Zhou Committed by Alex Deucher
Browse files

drm/amdgpu: gds bo must not be per-vm-bo 



In per-vm-bo case, there could be no bo list.
But gds bo created from user space  must be passed to bo list.
So adding a check to prevent to creat gds bo as per-vm-bo.

Signed-off-by: default avatarChunming Zhou <david1.zhou@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 01d98506

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

+7 −0
Original line number Diff line number Diff line
@@ -236,6 +236,13 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data, 
	/* create a gem object to contain this object in */

	if (args->in.domains & (AMDGPU_GEM_DOMAIN_GDS |

	    AMDGPU_GEM_DOMAIN_GWS | AMDGPU_GEM_DOMAIN_OA)) {

		if (flags & AMDGPU_GEM_CREATE_VM_ALWAYS_VALID) {

			/* if gds bo is created from user space, it must be

			 * passed to bo list

			 */

			DRM_ERROR("GDS bo cannot be per-vm-bo\n");

			return -EINVAL;

		}

		flags |= AMDGPU_GEM_CREATE_NO_CPU_ACCESS;

		if (args->in.domains == AMDGPU_GEM_DOMAIN_GDS)

			size = size << AMDGPU_GDS_SHIFT;