Commit ee4c9a93 authored Jun 07, 2023 by Bikash Hazarika Committed by Greg Kroah-Hartman Aug 11, 2023

scsi: qla2xxx: Fix potential NULL pointer dereference



commit 464ea494a40c6e3e0e8f91dd325408aaf21515ba upstream.

Klocwork tool reported 'cur_dsd' may be dereferenced.  Add fix to validate
pointer before dereferencing the pointer.

Cc: stable@vger.kernel.org
Signed-off-by: Bikash Hazarika <bhazarika@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20230607113843.37185-3-njavali@marvell.com


Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4647d2e8

drivers/scsi/qla2xxx/qla_iocb.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -603,7 +603,8 @@ qla24xx_build_scsi_type_6_iocbs(srb_t sp, struct cmd_type_6 cmd_pkt,
		((uint32_t )(&cmd_pkt->entry_type)) = cpu_to_le32(COMMAND_TYPE_6);

		/* No data transfer */
		if (!scsi_bufflen(cmd) \|\| cmd->sc_data_direction == DMA_NONE) {
		if (!scsi_bufflen(cmd) \|\| cmd->sc_data_direction == DMA_NONE \|\|
		tot_dsds == 0) {
		cmd_pkt->byte_count = cpu_to_le32(0);
		return 0;
		}