Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee467fba authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

sfc: fix an off by one bug 



This bug is harmless because it's just a sanity check and we always
pass valid values for "encap_type" but the test is off by one.

Fixes: 9b410801 ("sfc: insert catch-all filters for encapsulated traffic")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarBert Kenward <bkenward@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ac6e058b

drivers/net/ethernet/sfc/ef10.c

+1 −1
Original line number Diff line number Diff line
@@ -5134,7 +5134,7 @@ static int efx_ef10_filter_insert_def(struct efx_nic *efx, 


		/* quick bounds check (BCAST result impossible) */

		BUILD_BUG_ON(EFX_EF10_BCAST != 0);

		if (encap_type > ARRAY_SIZE(map) || map[encap_type] == 0) {

		if (encap_type >= ARRAY_SIZE(map) || map[encap_type] == 0) {

			WARN_ON(1);

			return -EINVAL;

		}