Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee0d8d84 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

ipx: call ipxitf_put() in ioctl error path 



We should call ipxitf_put() if the copy_to_user() fails.

Reported-by: default avatar李强 <liqiang6-s@360.cn>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9da3242e

net/ipx/af_ipx.c

+2 −3
Original line number Diff line number Diff line
@@ -1168,11 +1168,10 @@ static int ipxitf_ioctl(unsigned int cmd, void __user *arg) 
		sipx->sipx_network	= ipxif->if_netnum;

		memcpy(sipx->sipx_node, ipxif->if_node,

			sizeof(sipx->sipx_node));

		rc = -EFAULT;

		rc = 0;

		if (copy_to_user(arg, &ifr, sizeof(ifr)))

			break;

			rc = -EFAULT;

		ipxitf_put(ipxif);

		rc = 0;

		break;

	}

	case SIOCAIPXITFCRT: