Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ede8342b authored by Sifan Naeem's avatar Sifan Naeem Committed by Mark Brown
Browse files

spi: img-spfi: Setup TRANSACTION register before CONTROL register 



Setting the transfer length in the TRANSACTION register after the
CONTROL register is programmed causes intermittent timeout issues in
SPFI transfers when using the SPI framework to control the CS GPIO
lines.  To avoid this issue, set transfer length before programming
the CONTROL register.

Signed-off-by: default avatarSifan Naeem <sifan.naeem@imgtec.com>
Signed-off-by: default avatarAndrew Bresticker <abrestic@chromium.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b6fe3977

drivers/spi/spi-img-spfi.c

+3 −2
Original line number Diff line number Diff line
@@ -434,6 +434,9 @@ static void img_spfi_config(struct spi_master *master, struct spi_device *spi, 
	val |= div << SPFI_DEVICE_PARAMETER_BITCLK_SHIFT;

	spfi_writel(spfi, val, SPFI_DEVICE_PARAMETER(spi->chip_select));



	spfi_writel(spfi, xfer->len << SPFI_TRANSACTION_TSIZE_SHIFT,

		    SPFI_TRANSACTION);



	val = spfi_readl(spfi, SPFI_CONTROL);

	val &= ~(SPFI_CONTROL_SEND_DMA | SPFI_CONTROL_GET_DMA);

	if (xfer->tx_buf)
@@ -452,8 +455,6 @@ static void img_spfi_config(struct spi_master *master, struct spi_device *spi, 
					      &master->cur_msg->transfers))

		val |= SPFI_CONTROL_CONTINUE;

	spfi_writel(spfi, val, SPFI_CONTROL);

	spfi_writel(spfi, xfer->len << SPFI_TRANSACTION_TSIZE_SHIFT,

		    SPFI_TRANSACTION);

}



static int img_spfi_transfer_one(struct spi_master *master,