Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit edb6cb3d authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jiri Kosina
Browse files

HID: alps: Save a memory allocation in 't4_read_write_register()' when writing data 



if 'read_flag' is false, there is no need to allocate and free memory.
We can simply avoid the memory allocation and pass NULL to kfree.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 605f0772

drivers/hid/hid-alps.c

+2 −2
Original line number Diff line number Diff line
@@ -171,7 +171,7 @@ static int t4_read_write_register(struct hid_device *hdev, u32 address, 
	int ret;

	u16 check_sum;

	u8 *input;

	u8 *readbuf;

	u8 *readbuf = NULL;



	input = kzalloc(T4_FEATURE_REPORT_LEN, GFP_KERNEL);

	if (!input)
@@ -204,8 +204,8 @@ static int t4_read_write_register(struct hid_device *hdev, u32 address, 
		goto exit;

	}



	readbuf = kzalloc(T4_FEATURE_REPORT_LEN, GFP_KERNEL);

	if (read_flag) {

		readbuf = kzalloc(T4_FEATURE_REPORT_LEN, GFP_KERNEL);

		if (!readbuf) {

			ret = -ENOMEM;

			goto exit;