Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit edb5e5f6 authored by Lars Ellenberg's avatar Lars Ellenberg Committed by Jens Axboe
Browse files

drbd: fix spurious alert level printk 



When accessing out meta data area on disk, we double check the
plausibility of the requested sector offsets, and are very noisy about
it if they look suspicious.

During initial read of our "superblock", for "external" meta data,
this triggered because the range estimate returned by
drbd_md_last_sector() was still wrong.

Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 5fb3bc4d

drivers/block/drbd/drbd_main.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -3270,6 +3270,10 @@ int drbd_md_read(struct drbd_device *device, struct drbd_backing_dev *bdev) 
	 * and read it. */

	 * and read it. */

	bdev->md.meta_dev_idx = bdev->disk_conf->meta_dev_idx;

	bdev->md.meta_dev_idx = bdev->disk_conf->meta_dev_idx;

	bdev->md.md_offset = drbd_md_ss(bdev);

	bdev->md.md_offset = drbd_md_ss(bdev);

	/* Even for (flexible or indexed) external meta data,

	 * initially restrict us to the 4k superblock for now.

	 * Affects the paranoia out-of-range access check in drbd_md_sync_page_io(). */

	bdev->md.md_size_sect = 8;





	if (drbd_md_sync_page_io(device, bdev, bdev->md.md_offset, READ)) {

	if (drbd_md_sync_page_io(device, bdev, bdev->md.md_offset, READ)) {

		/* NOTE: can't do normal error processing here as this is

		/* NOTE: can't do normal error processing here as this is