Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed7db983 authored by Huacai Chen's avatar Huacai Chen Committed by Greg Kroah-Hartman
Browse files

drm/qxl: Use correct notify port address when creating cursor ring 



commit 80e5f89da3ab949fbbf1cae01dfaea29f5483a75 upstream.

The command ring and cursor ring use different notify port addresses
definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in
qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring
and cursor ring. This doesn't cause any problems now, because QEMU's
behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same.
However, QEMU's behavior may be change in future, so let's fix it.

P.S.: In the X.org QXL driver, the notify port address of cursor ring
      is correct.

Signed-off-by: default avatarHuacai Chen <chenhc@lemote.com>
Cc: <stable@vger.kernel.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1585635488-17507-1-git-send-email-chenhc@lemote.com


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f3f05971

drivers/gpu/drm/qxl/qxl_kms.c

+1 −1
Original line number Diff line number Diff line
@@ -181,7 +181,7 @@ int qxl_device_init(struct qxl_device *qdev, 
				&(qdev->ram_header->cursor_ring_hdr),

				sizeof(struct qxl_command),

				QXL_CURSOR_RING_SIZE,

				qdev->io_base + QXL_IO_NOTIFY_CMD,

				qdev->io_base + QXL_IO_NOTIFY_CURSOR,

				false,

				&qdev->cursor_event);