Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed65a4dc authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/ucma: Fix use-after-free access in ucma_close 



The error in ucma_create_id() left ctx in the list of contexts belong
to ucma file descriptor. The attempt to close this file descriptor causes
to use-after-free accesses while iterating over such list.

Fixes: 75216638 ("RDMA/cma: Export rdma cm interface to userspace")
Reported-by: default avatar <syzbot+dcfd344365a56fbebd0f@syzkaller.appspotmail.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarSean Hefty <sean.hefty@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 2975d5de

drivers/infiniband/core/ucma.c

+3 −0
Original line number Diff line number Diff line
@@ -497,6 +497,9 @@ static ssize_t ucma_create_id(struct ucma_file *file, const char __user *inbuf, 
	mutex_lock(&mut);

	idr_remove(&ctx_idr, ctx->id);

	mutex_unlock(&mut);

	mutex_lock(&file->mut);

	list_del(&ctx->list);

	mutex_unlock(&file->mut);

	kfree(ctx);

	return ret;

}