Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed596a4a authored by Oliver Neukum's avatar Oliver Neukum Committed by Jiri Kosina
Browse files

HID: elo: kill not flush the work 



Flushing a work that reschedules itself is not a sensible operation. It needs
to be killed. Failure to do so leads to a kernel panic in the timer code.

CC: stable@vger.kernel.org
Signed-off-by: default avatarOliver Neukum <ONeukum@suse.com>
Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent dcc4c2f6

drivers/hid/hid-elo.c

+1 −1
Original line number Diff line number Diff line
@@ -261,7 +261,7 @@ static void elo_remove(struct hid_device *hdev) 
	struct elo_priv *priv = hid_get_drvdata(hdev);



	hid_hw_stop(hdev);

	flush_workqueue(wq);

	cancel_delayed_work_sync(&priv->work);

	kfree(priv);

}