Commit ed224150 authored Nov 13, 2018 by Denis V. Lunev Committed by Greg Kroah-Hartman Dec 13, 2019

dlm: fix possible call to kfree() for non-initialized pointer



[ Upstream commit 58a923adf4d9aca8bf7205985c9c8fc531c65d72 ]

Technically dlm_config_nodes() could return error and keep nodes
uninitialized. After that on the fail path of we'll call kfree()
for that uninitialized value.

The patch is simple - we should just initialize nodes with NULL.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fd12b061

fs/dlm/member.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -671,7 +671,7 @@ int dlm_ls_stop(struct dlm_ls *ls)
		int dlm_ls_start(struct dlm_ls *ls)
		{
		struct dlm_recover rv, rv_old;
		struct dlm_config_node *nodes;
		struct dlm_config_node *nodes = NULL;
		int error, count;

		rv = kzalloc(sizeof(*rv), GFP_NOFS);