Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecf79d15 authored by Markus Elfring's avatar Markus Elfring Committed by Benjamin Gaignard
Browse files

drm/sti: Reduce function calls for sequence output at five places 



Some data were put into a sequence by separate function calls.
Print the same data by five single function calls instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarBenjamin Gaignard <benjamin.gaignard@linaro.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1f5c5b0d-77c4-6efc-7906-cee76c33d2b0@users.sourceforge.net
parent adea1db2

drivers/gpu/drm/sti/sti_gdp.c

+1 −2
Original line number Diff line number Diff line
@@ -266,8 +266,7 @@ static void gdp_node_dump_node(struct seq_file *s, struct sti_gdp_node *node) 
	seq_printf(s, "\n\tKEY2 0x%08X", node->gam_gdp_key2);

	seq_printf(s, "\n\tPPT  0x%08X", node->gam_gdp_ppt);

	gdp_dbg_ppt(s, node->gam_gdp_ppt);

	seq_printf(s, "\n\tCML  0x%08X", node->gam_gdp_cml);

	seq_puts(s, "\n");

	seq_printf(s, "\n\tCML  0x%08X\n", node->gam_gdp_cml);

}



static int gdp_node_dbg_show(struct seq_file *s, void *arg)

drivers/gpu/drm/sti/sti_hda.c

+2 −4
Original line number Diff line number Diff line
@@ -320,8 +320,7 @@ static void hda_dbg_awg_microcode(struct seq_file *s, void __iomem *reg) 
{

	unsigned int i;



	seq_puts(s, "\n\n");

	seq_puts(s, "  HDA AWG microcode:");

	seq_puts(s, "\n\n  HDA AWG microcode:");

	for (i = 0; i < AWG_MAX_INST; i++) {

		if (i % 8 == 0)

			seq_printf(s, "\n  %04X:", i);
@@ -333,8 +332,7 @@ static void hda_dbg_video_dacs_ctrl(struct seq_file *s, void __iomem *reg) 
{

	u32 val = readl(reg);



	seq_puts(s, "\n");

	seq_printf(s, "\n  %-25s 0x%08X", "VIDEO_DACS_CONTROL", val);

	seq_printf(s, "\n\n  %-25s 0x%08X", "VIDEO_DACS_CONTROL", val);

	seq_puts(s, "\tHD DACs ");

	seq_puts(s, val & DAC_CFG_HD_HZUVW_OFF_MASK ? "disabled" : "enabled");

}

drivers/gpu/drm/sti/sti_hdmi.c

+2 −4
Original line number Diff line number Diff line
@@ -692,8 +692,7 @@ static int hdmi_dbg_show(struct seq_file *s, void *data) 
	DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD4, HDMI_IFRAME_SLOT_AVI);

	DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD5, HDMI_IFRAME_SLOT_AVI);

	DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_AVI);

	seq_puts(s, "\n");

	seq_printf(s, "\n AUDIO Infoframe (Data Island slot N=%d):",

	seq_printf(s, "\n\n AUDIO Infoframe (Data Island slot N=%d):",

		   HDMI_IFRAME_SLOT_AUDIO);

	DBGFS_DUMP_DI(HDMI_SW_DI_N_HEAD_WORD, HDMI_IFRAME_SLOT_AUDIO);

	DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD0, HDMI_IFRAME_SLOT_AUDIO);
@@ -703,8 +702,7 @@ static int hdmi_dbg_show(struct seq_file *s, void *data) 
	DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD4, HDMI_IFRAME_SLOT_AUDIO);

	DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD5, HDMI_IFRAME_SLOT_AUDIO);

	DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_AUDIO);

	seq_puts(s, "\n");

	seq_printf(s, "\n VENDOR SPECIFIC Infoframe (Data Island slot N=%d):",

	seq_printf(s, "\n\n VENDOR SPECIFIC Infoframe (Data Island slot N=%d):",

		   HDMI_IFRAME_SLOT_VENDOR);

	DBGFS_DUMP_DI(HDMI_SW_DI_N_HEAD_WORD, HDMI_IFRAME_SLOT_VENDOR);

	DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD0, HDMI_IFRAME_SLOT_VENDOR);