Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eccb6638 authored by Axel Lin's avatar Axel Lin Committed by Bryan Wu
Browse files

leds: lm3642: Return proper error in lm3642_[torch|strobe]_pin_store error paths 



Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarG.Shark Jeong <gshark.jeong@gmail.com>
Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
parent 9489e9dc

drivers/leds/leds-lm3642.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -201,10 +201,10 @@ static ssize_t lm3642_torch_pin_store(struct device *dev, 
	return size;

	return size;

out:

out:

	dev_err(chip->dev, "%s:i2c access fail to register\n", __func__);

	dev_err(chip->dev, "%s:i2c access fail to register\n", __func__);

	return size;

	return ret;

out_strtoint:

out_strtoint:

	dev_err(chip->dev, "%s: fail to change str to int\n", __func__);

	dev_err(chip->dev, "%s: fail to change str to int\n", __func__);

	return size;

	return ret;

}

}





static DEVICE_ATTR(torch_pin, 0666, NULL, lm3642_torch_pin_store);

static DEVICE_ATTR(torch_pin, 0666, NULL, lm3642_torch_pin_store);
@@ -258,10 +258,10 @@ static ssize_t lm3642_strobe_pin_store(struct device *dev, 
	return size;

	return size;

out:

out:

	dev_err(chip->dev, "%s:i2c access fail to register\n", __func__);

	dev_err(chip->dev, "%s:i2c access fail to register\n", __func__);

	return size;

	return ret;

out_strtoint:

out_strtoint:

	dev_err(chip->dev, "%s: fail to change str to int\n", __func__);

	dev_err(chip->dev, "%s: fail to change str to int\n", __func__);

	return size;

	return ret;

}

}





static DEVICE_ATTR(strobe_pin, 0666, NULL, lm3642_strobe_pin_store);

static DEVICE_ATTR(strobe_pin, 0666, NULL, lm3642_strobe_pin_store);