Commit ecc8805a authored Dec 11, 2023 by David Howells Committed by Greg Kroah-Hartman Jan 08, 2024

afs: Fix the dynamic root's d_delete to always delete unused dentries



[ Upstream commit 71f8b55bc30e82d6355e07811213d847981a32e2 ]

Fix the afs dynamic root's d_delete function to always delete unused
dentries rather than only deleting them if they're positive.  With things
as they stand upstream, negative dentries stemming from failed DNS lookups
stick around preventing retries.

Fixes: 66c7e1d3 ("afs: Split the dynroot stuff out and give it its own ops tables")
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: Markus Suvanto <markus.suvanto@gmail.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e1e51040

fs/afs/dynroot.c

+1 −12

Original line number	Diff line number	Diff line
		@@ -172,20 +172,9 @@ static int afs_dynroot_d_revalidate(struct dentry *dentry, unsigned int flags)
		return 1;
		}

		/*
		* Allow the VFS to enquire as to whether a dentry should be unhashed (mustn't
		* sleep)
		* - called from dput() when d_count is going to 0.
		* - return 1 to request dentry be unhashed, 0 otherwise
		*/
		static int afs_dynroot_d_delete(const struct dentry *dentry)
		{
		return d_really_is_positive(dentry);
		}

		const struct dentry_operations afs_dynroot_dentry_operations = {
		.d_revalidate = afs_dynroot_d_revalidate,
		.d_delete = afs_dynroot_d_delete,
		.d_delete = always_delete_dentry,
		.d_release = afs_d_release,
		.d_automount = afs_d_automount,
		};