Commit ecb2caae authored Jul 19, 2016 by Nicholas Mc Guire Committed by Alex Deucher Jul 29, 2016

drm/radeon/ci add comment to document intentionally unreachable code



 commit d967be9b ("drm/radeon/ci: disable needless sclk changes")
 introduces an unreachable if(C != C) conditional code section
 flagged by coccinelle script bad_conditional.cocci:

 Add a comment to make it clear that this is intentional.

 Fixes: d967be9b ("drm/radeon/ci: disable needless sclk changes")

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 23a1a9e5

drivers/gpu/drm/radeon/ci_dpm.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -3843,7 +3843,10 @@ static void ci_find_dpm_states_clocks_in_dpm_table(struct radeon_device *rdev,
		if (i >= sclk_table->count) {
		pi->need_update_smu7_dpm_table \|= DPMTABLE_OD_UPDATE_SCLK;
		} else {
		/* XXX check display min clock requirements */
		/* XXX The current code always reprogrammed the sclk levels,
		* but we don't currently handle disp sclk requirements
		* so just skip it.
		*/
		if (CISLAND_MINIMUM_ENGINE_CLOCK != CISLAND_MINIMUM_ENGINE_CLOCK)
		pi->need_update_smu7_dpm_table \|= DPMTABLE_UPDATE_SCLK;
		}