Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebdfea81 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mauro Carvalho Chehab
Browse files

[media] s5p-fimc: Remove sclk_cam clock handling 



There are 2 separate clock outputs available in the SoC for external sensors.
These two clocks can be shared among all FIMC entities and there is
currently no any arbitration of the clocks in the driver.

So make the capture driver not touching these clocks and let them be
be properly handled at the media device driver level, enabling proper
arbitration between FIMC entities.

Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 96a85742

drivers/media/video/s5p-fimc/fimc-core.c

+2 −10
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ 
#include "fimc-core.h"



static char *fimc_clocks[MAX_FIMC_CLOCKS] = {

	"sclk_fimc", "fimc", "sclk_cam"

	"sclk_fimc", "fimc"

};



static struct fimc_fmt fimc_formats[] = {
@@ -1636,7 +1636,6 @@ static int fimc_probe(struct platform_device *pdev) 
	struct samsung_fimc_driverdata *drv_data;

	struct s5p_platform_fimc *pdata;

	int ret = 0;

	int cap_input_index = -1;



	dev_dbg(&pdev->dev, "%s():\n", __func__);
@@ -1689,14 +1688,6 @@ static int fimc_probe(struct platform_device *pdev) 
		goto err_req_region;

	}



	fimc->num_clocks = MAX_FIMC_CLOCKS - 1;



	/* Check if a video capture node needs to be registered. */

	if (pdata && pdata->num_clients > 0) {

		cap_input_index = 0;

		fimc->num_clocks++;

	}



	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);

	if (!res) {

		dev_err(&pdev->dev, "failed to get IRQ resource\n");
@@ -1705,6 +1696,7 @@ static int fimc_probe(struct platform_device *pdev) 
	}

	fimc->irq = res->start;



	fimc->num_clocks = MAX_FIMC_CLOCKS;

	ret = fimc_clk_get(fimc);

	if (ret)

		goto err_regs_unmap;

drivers/media/video/s5p-fimc/fimc-core.h

+1 −2
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ 


/* Time to wait for next frame VSYNC interrupt while stopping operation. */

#define FIMC_SHUTDOWN_TIMEOUT	((100*HZ)/1000)

#define MAX_FIMC_CLOCKS		3

#define MAX_FIMC_CLOCKS		2

#define MODULE_NAME		"s5p-fimc"

#define FIMC_MAX_DEVS		4

#define FIMC_MAX_OUT_BUFS	4
@@ -46,7 +46,6 @@ 
enum {

	CLK_BUS,

	CLK_GATE,

	CLK_CAM,

};



enum fimc_dev_flags {