Commit eb46996f authored Jan 08, 2006 by Ashutosh Naik Committed by Linus Torvalds Jan 08, 2006

[PATCH] kernel/module.c: remove redundant spinlock in resolve_symbol()



Remove the redundant spinlock in the function resolve_symbol() as we are
not altering the module list, and we already hold the semaphore.

Signed-off-by: Ashutosh Naik <ashutosh.naik@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 349aef0b

kernel/module.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -958,7 +958,6 @@ static unsigned long resolve_symbol(Elf_Shdr *sechdrs,
		unsigned long ret;
		const unsigned long *crc;

		spin_lock_irq(&modlist_lock);
		ret = __find_symbol(name, &owner, &crc, mod->license_gplok);
		if (ret) {
		/* use_module can fail due to OOM, or module unloading */
		@@ -966,7 +965,6 @@ static unsigned long resolve_symbol(Elf_Shdr *sechdrs,
		!use_module(mod, owner))
		ret = 0;
		}
		spin_unlock_irq(&modlist_lock);
		return ret;
		}