Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb37430d authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Greg Kroah-Hartman
Browse files

staging: ks7010: call 'hostif_mib_set_request_int' instead of 'hostif_mib_set_request_bool' 



'hostif_mib_set_request_bool' function receives a bool as value and
send the received value with MIB_VALUE_TYPE_BOOL type. There is
one case where the value passed is not a boolean one but
'MCAST_FILTER_PROMISC' which is '2'. Call hostif_mib_set_request_int
instead for related multicast enumeration. This changes original
code behaviour but seems to be the right way to do this.

Fixes: 8ce76bff ("staging: ks7010: add new helpers to achieve mib set request and simplify code")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 69a1d98c

drivers/staging/ks7010/ks_hostif.c

+6 −6
Original line number Diff line number Diff line
@@ -1842,14 +1842,14 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv) 
	memset(set_address, 0, NIC_MAX_MCAST_LIST * ETH_ALEN);



	if (dev->flags & IFF_PROMISC) {

		hostif_mib_set_request_bool(priv, LOCAL_MULTICAST_FILTER,

		hostif_mib_set_request_int(priv, LOCAL_MULTICAST_FILTER,

					   MCAST_FILTER_PROMISC);

		goto spin_unlock;

	}



	if ((netdev_mc_count(dev) > NIC_MAX_MCAST_LIST) ||

	    (dev->flags & IFF_ALLMULTI)) {

		hostif_mib_set_request_bool(priv, LOCAL_MULTICAST_FILTER,

		hostif_mib_set_request_int(priv, LOCAL_MULTICAST_FILTER,

					   MCAST_FILTER_MCASTALL);

		goto spin_unlock;

	}
@@ -1866,7 +1866,7 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv) 
					       ETH_ALEN * mc_count);

	} else {

		priv->sme_i.sme_flag |= SME_MULTICAST;

		hostif_mib_set_request_bool(priv, LOCAL_MULTICAST_FILTER,

		hostif_mib_set_request_int(priv, LOCAL_MULTICAST_FILTER,

					   MCAST_FILTER_MCAST);

	}