Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea370943 authored by Doron Cohen's avatar Doron Cohen Committed by Mauro Carvalho Chehab
Browse files

[media] siano: apply debug flag to module level 



Siano modules already had sms_dbg flag which is a module parameter which
sets the debug mode so module prints messages to dmesg for debugging.
The variable was static therefore apply only to the file which defines
the module. In modules as smsmdtv.ko that contain a few files, the debug
flag applied only for functions in that main file.
flag was changed to be non-static and therefore can be accessed by all
module files (although it is still not exported out of the module).

Signed-off-by: default avatarDoron Cohen <doronc@siano-ms.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent fda516b7

drivers/media/dvb/siano/sms-cards.c

+0 −4
Original line number Diff line number Diff line
@@ -20,10 +20,6 @@ 
#include "sms-cards.h"

#include "smsir.h"



static int sms_dbg;

module_param_named(cards_dbg, sms_dbg, int, 0644);

MODULE_PARM_DESC(cards_dbg, "set debug level (info=1, adv=2 (or-able))");



static struct sms_board sms_boards[] = {

	[SMS_BOARD_UNKNOWN] = {

		.name	= "Unknown board",

drivers/media/dvb/siano/smscoreapi.c

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ 
#include "smsir.h"

#include "smsendian.h"



static int sms_dbg;

int sms_dbg;

module_param_named(debug, sms_dbg, int, 0644);

MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");

drivers/media/dvb/siano/smscoreapi.h

+1 −0
Original line number Diff line number Diff line
@@ -751,6 +751,7 @@ int smscore_led_state(struct smscore_device_t *core, int led); 




/* ------------------------------------------------------------------------ */

extern int sms_dbg;



#define DBG_INFO 1

#define DBG_ADV  2

drivers/media/dvb/siano/smsdvb.c

+0 −4
Original line number Diff line number Diff line
@@ -60,10 +60,6 @@ struct smsdvb_client_t { 
static struct list_head g_smsdvb_clients;

static struct mutex g_smsdvb_clientslock;



static int sms_dbg;

module_param_named(debug, sms_dbg, int, 0644);

MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");



/* Events that may come from DVB v3 adapter */

static void sms_board_dvb3_event(struct smsdvb_client_t *client,

		enum SMS_DVB3_EVENTS event) {

drivers/media/dvb/siano/smsusb.c

+0 −4
Original line number Diff line number Diff line
@@ -29,10 +29,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. 
#include "sms-cards.h"

#include "smsendian.h"



static int sms_dbg;

module_param_named(debug, sms_dbg, int, 0644);

MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");



#define USB1_BUFFER_SIZE		0x1000

#define USB2_BUFFER_SIZE		0x4000