Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea1dd4e1 authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

[PATCH] libata: clear only affected flags during ata_dev_configure() 



ata_dev_configure() should not clear dynamic device flags determined
elsewhere.  Lower eight bits are reserved for feature flags, define
ATA_DFLAG_CFG_MASK and clear only those bits before configuring
device.  Without this patch, ATA_DFLAG_PIO gets turned off during
revalidation making PIO mode unuseable.

Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 198e0fed

drivers/scsi/libata-core.c

+1 −1
Original line number Diff line number Diff line
@@ -1241,7 +1241,7 @@ static int ata_dev_configure(struct ata_port *ap, struct ata_device *dev, 
		       id[84], id[85], id[86], id[87], id[88]);



	/* initialize to-be-configured parameters */

	dev->flags = 0;

	dev->flags &= ~ATA_DFLAG_CFG_MASK;

	dev->max_sectors = 0;

	dev->cdb_len = 0;

	dev->n_sectors = 0;

include/linux/libata.h

+1 −0
Original line number Diff line number Diff line
@@ -122,6 +122,7 @@ enum { 
	/* struct ata_device stuff */

	ATA_DFLAG_LBA		= (1 << 0), /* device supports LBA */

	ATA_DFLAG_LBA48		= (1 << 1), /* device supports LBA48 */

	ATA_DFLAG_CFG_MASK	= (1 << 8) - 1,



	ATA_DFLAG_PIO		= (1 << 8), /* device currently in PIO mode */