Commit e9d126cd authored Aug 09, 2009 by Dan Carpenter Committed by John W. Linville Aug 10, 2009

ar9170: fix read & write outside array bounds

queue == __AR9170_NUM_TXQ would cause a bug on the next line.

found by Smatch ( http://repo.or.cz/w/smatch.git

 ).

Cc: stable@kernel.org
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@web.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 363ec561

drivers/net/wireless/ath/ar9170/main.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1967,13 +1967,14 @@ static int ar9170_conf_tx(struct ieee80211_hw *hw, u16 queue,
		int ret;

		mutex_lock(&ar->mutex);
		if ((param) && !(queue > __AR9170_NUM_TXQ)) {
		if (queue < __AR9170_NUM_TXQ) {
		memcpy(&ar->edcf[ar9170_qos_hwmap[queue]],
		param, sizeof(*param));

		ret = ar9170_set_qos(ar);
		} else
		} else {
		ret = -EINVAL;
		}

		mutex_unlock(&ar->mutex);
		return ret;