staging: dgnc: remove pci_unregister_driver (e9961fc1) · Commits · e / devices / android_kernel_oneplus_sm7250

If pci_register_driver() fails then dgnc_NumBoards can never be more than zero. dgnc_NumBoards is incremented only at the end of a successful probe. And moreover if the pci driver has failed to register then we never need to unregister it. Lets just print the warning, perform the cleanup and exit with the error code. Signed-off-by:

Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/dgnc/dgnc_driver.c

+5 −14

Original line number	Diff line number	Diff line
		@@ -181,23 +181,14 @@ static int __init dgnc_init_module(void)
		* Find and configure all the cards
		*/
		rc = pci_register_driver(&dgnc_driver);

		/*
		* If something went wrong in the scan, bail out of driver.
		*/
		if (rc < 0) {
		/* Only unregister if it was actually registered. */
		if (dgnc_NumBoards)
		pci_unregister_driver(&dgnc_driver);
		else
		if (rc) {
		pr_warn("WARNING: dgnc driver load failed. No Digi Neo or Classic boards found.\n");

		dgnc_cleanup_module();
		} else {
		dgnc_create_driver_sysfiles(&dgnc_driver);
		return rc;
		}
		dgnc_create_driver_sysfiles(&dgnc_driver);

		return rc;
		return 0;
		}

		module_init(dgnc_init_module);