Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e91c3dfc authored by William Breathitt Gray's avatar William Breathitt Gray Committed by Jonathan Cameron
Browse files

iio: 104-quad-8: Fix active level mismatch for the preset enable option 



The set_to_preset_on_index sysfs attribute provides a boolean
configuration option to enable a preset operation on the respective
channel's counter when Index occurs. However, the corresponding
configuration bit on the Input/Output Control register must be set low
to enable the preset operation.

This patch inverts the internal driver boolean logic exposed via the
set_to_preset_on_index attribute in order to correctly configure the
device which expects an active low bit.

Fixes: 28e5d3bb ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
Signed-off-by: default avatarWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 7e1c4058

drivers/iio/counter/104-quad-8.c

+4 −1
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ static ssize_t quad8_read_set_to_preset_on_index(struct iio_dev *indio_dev, 
	const struct quad8_iio *const priv = iio_priv(indio_dev);



	return snprintf(buf, PAGE_SIZE, "%u\n",

		priv->preset_enable[chan->channel]);

		!priv->preset_enable[chan->channel]);

}



static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
@@ -250,6 +250,9 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev, 
	if (ret)

		return ret;



	/* Preset enable is active low in Input/Output Control register */

	preset_enable = !preset_enable;



	priv->preset_enable[chan->channel] = preset_enable;



	ior_cfg = priv->ab_enable[chan->channel] |