Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e903fbd4 authored by Reinette Chatre's avatar Reinette Chatre Committed by John W. Linville
Browse files

iwlwifi: fix merge sequence: exit on error before state change 



The intention behind the original patch:
"iwlwifi: fix possible read attempt on ucode that is not available"
was to exit before any state is changed. Due to its submission directly
to 2.6.24 it was not clear how this relates to the latest iwlwifi work.

This patch does exactly the same as the previous patch, just earlier to
prevent any state from being changed if there is an error.

Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent ff5059ef

drivers/net/wireless/iwlwifi/iwl3945-base.c

+5 −5
Original line number Diff line number Diff line
@@ -6330,6 +6330,11 @@ static int __iwl3945_up(struct iwl3945_priv *priv) 
		return -ENODEV;

	}



	if (!priv->ucode_data_backup.v_addr || !priv->ucode_data.v_addr) {

		IWL_ERROR("ucode not available for device bringup\n");

		return -EIO;

	}



	/* If platform's RF_KILL switch is NOT set to KILL */

	if (iwl3945_read32(priv, CSR_GP_CNTRL) &

				CSR_GP_CNTRL_REG_FLAG_HW_RF_KILL_SW)
@@ -6342,11 +6347,6 @@ static int __iwl3945_up(struct iwl3945_priv *priv) 
		}

	}



	if (!priv->ucode_data_backup.v_addr || !priv->ucode_data.v_addr) {

		IWL_ERROR("ucode not available for device bringup\n");

		return -EIO;

	}



	iwl3945_write32(priv, CSR_INT, 0xFFFFFFFF);



	rc = iwl3945_hw_nic_init(priv);

drivers/net/wireless/iwlwifi/iwl4965-base.c

+5 −5
Original line number Diff line number Diff line
@@ -6755,6 +6755,11 @@ static int __iwl4965_up(struct iwl4965_priv *priv) 
		return -ENODEV;

	}



	if (!priv->ucode_data_backup.v_addr || !priv->ucode_data.v_addr) {

		IWL_ERROR("ucode not available for device bringup\n");

		return -EIO;

	}



	/* If platform's RF_KILL switch is NOT set to KILL */

	if (iwl4965_read32(priv, CSR_GP_CNTRL) &

				CSR_GP_CNTRL_REG_FLAG_HW_RF_KILL_SW)
@@ -6767,11 +6772,6 @@ static int __iwl4965_up(struct iwl4965_priv *priv) 
		}

	}



	if (!priv->ucode_data_backup.v_addr || !priv->ucode_data.v_addr) {

		IWL_ERROR("ucode not available for device bringup\n");

		return -EIO;

	}



	iwl4965_write32(priv, CSR_INT, 0xFFFFFFFF);



	rc = iwl4965_hw_nic_init(priv);