Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8d61a74 authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: remove redundant set_page_dirty from write_compacted_summaries 



Previously, set_page_dirty is called every time after writting one summary info
into compacted summary page,
To avoid redundant set_page_dirty, we only call set_page_dirty before release
page.

Signed-off-by: default avatarYu Chao <chao2.yu@samsung.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk.kim@samsung.com>
parent ea91e9b0

fs/f2fs/segment.c

+4 −4
Original line number Diff line number Diff line
@@ -1138,8 +1138,6 @@ static void write_compacted_summaries(struct f2fs_sb_info *sbi, block_t blkaddr) 
						SUM_JOURNAL_SIZE);

	written_size += SUM_JOURNAL_SIZE;



	set_page_dirty(page);



	/* Step 3: write summary entries */

	for (i = CURSEG_HOT_DATA; i <= CURSEG_COLD_DATA; i++) {

		unsigned short blkoff;
@@ -1158,19 +1156,21 @@ static void write_compacted_summaries(struct f2fs_sb_info *sbi, block_t blkaddr) 
			summary = (struct f2fs_summary *)(kaddr + written_size);

			*summary = seg_i->sum_blk->entries[j];

			written_size += SUMMARY_SIZE;

			set_page_dirty(page);



			if (written_size + SUMMARY_SIZE <= PAGE_CACHE_SIZE -

							SUM_FOOTER_SIZE)

				continue;



			set_page_dirty(page);

			f2fs_put_page(page, 1);

			page = NULL;

		}

	}

	if (page)

	if (page) {

		set_page_dirty(page);

		f2fs_put_page(page, 1);

	}

}



static void write_normal_summaries(struct f2fs_sb_info *sbi,

					block_t blkaddr, int type)