Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8bd0dff authored by Steffen Maier's avatar Steffen Maier Committed by Greg Kroah-Hartman
Browse files

scsi: zfcp: fix missing zfcp_port reference put on -EBUSY from port_remove 



commit d27e5e07f9c49bf2a6a4ef254ce531c1b4fb5a38 upstream.

With this early return due to zfcp_unit child(ren), we don't use the
zfcp_port reference from the earlier zfcp_get_port_by_wwpn() anymore and
need to put it.

Signed-off-by: default avatarSteffen Maier <maier@linux.ibm.com>
Fixes: d99b601b ("[SCSI] zfcp: restore refcount check on port_remove")
Cc: <stable@vger.kernel.org> #3.7+
Reviewed-by: default avatarJens Remus <jremus@linux.ibm.com>
Reviewed-by: default avatarBenjamin Block <bblock@linux.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c18a0ecc

drivers/s390/scsi/zfcp_sysfs.c

+1 −0
Original line number Diff line number Diff line
@@ -261,6 +261,7 @@ static ssize_t zfcp_sysfs_port_remove_store(struct device *dev, 
	if (atomic_read(&port->units) > 0) {

		retval = -EBUSY;

		mutex_unlock(&zfcp_sysfs_port_units_mutex);

		put_device(&port->dev); /* undo zfcp_get_port_by_wwpn() */

		goto out;

	}

	/* port is about to be removed, so no more unit_add */